Fix 1429: mounted.getLinked() is null #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR contains a range of units. Is this intentional? |
Yes, since the root issue only impacted the Aero equipment view, I wanted to add coverage for the full range of unit types in the new test to catch any similar single-type equipment view issues. |
SJuliez
approved these changes
Feb 20, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the MML addendum to the MM fix to #1429.
Technically it isn't necessary as the offending calls will be handled correctly once MegaMek/megamek#5176 goes in, but this PR cleans the original calls up as passing
nullas a weapon value is ugh.This PR also adds unit tests to:
EquipmentTableModelof each unit type can be populated and read;EquipmentTableModel.getDamageString()(used to populate the damage field in the table) works correctly with Aerospace, CI, and Artillery;said unit tests to be run via the "Verification/test" gradle task prior to any PR submissions.
There are still many, many areas within MML that need unit test coverage, but at least this gets the ball rolling.
NOTE:
The tests in this PR will continue to fail until MegaMek/megamek#5176 is pulled.