Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAM landing gear not placed correctly with compact engine or gyro. #106

Closed
snrdg102417 opened this issue Nov 13, 2017 · 2 comments
Closed

Comments

@snrdg102417
Copy link

On the HeavyMetal BattleMech Submissions forum is a challenge to make a BZK-F3 Hollander into a LAM.
I opened the Hollander file and made the changes to a LAM. I clicked the Validate Unit button the message Validation Passes. There are no messages Saving the file for the Hollander LAM does not display any messages. When I access the file a pop-up opens Message: Warning: Invalid unit, it might load incorrectly! Equipment that Failed to Load: Landing Gear. Opening Assign Criticals shown the landing gear but the weapons, ammo, heat sinks, and jump jets are present. The Gauss rifle and ammo are not shown even though they are in the Equipment tab.

Hollander NS LAM.zip

@neoancient neoancient changed the title MegaMekLab Version 0.43.4 LAM Conversion of Hollander from TRO 3055 LAM Conversion of Hollander from TRO 3055 Dec 12, 2017
@neoancient neoancient changed the title LAM Conversion of Hollander from TRO 3055 LAM landing gear not placed correctly with compact engine or gyro. Dec 12, 2017
neoancient added a commit to MegaMek/megamek that referenced this issue Dec 12, 2017
than in a fixed position.

The fixed position for landing gear was causing problems with compact
engines and/or gyros.

See MegaMek/megameklab#106: MegaMekLab Version 0.43.4 LAM Conversion of
Hollander from TRO 3055
@xStormforgex
Copy link

xStormforgex commented Dec 21, 2017

Not sure this issue is closed.

The LAM Side Torso Landing Gear critical slots are disappearing when adding a Compact Engine, Compact Gyro, Heavy Duty Gyro, or Small Cockpit. The CT Landing Gear crit is also moving from the #1 critical slot down to the first open slot after adding one of the above items.

Ex. in the case of the Small Cockpit/Heavy Duty Gyro, Landing Gear moves from the #1 CT slot to the #11 CT slot; with a Compact Gyro, Landing Gear moves from the #1 CT slot to the #9 CT slot, etc.

neoancient added a commit that referenced this issue Dec 22, 2017
Bug was introduced in previous fix for this issue.

Fixes #106: LAM landing gear not placed correctly with compact engine or
gyro.
@neoancient
Copy link
Member

I didn't pay close enough attention and was removing all landing gear instead of just the center torso when adjusting its critical slot. Placing the landing gear directly after the engine and gyro section is intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants