feat: added sensor range on minimap, added facing arrow on minimap #6446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scoppio
force-pushed
the
feat/minimap-sensor=facing
branch
from
c15ac08 to
cbc096d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6446 +/- ##
============================================
- Coverage 28.59% 28.57% -0.02%
- Complexity 14377 14381 +4
============================================
Files 2798 2798
Lines 274895 275057 +162
Branches 48630 48665 +35
============================================
+ Hits 78593 78601 +8
- Misses 191669 191822 +153
- Partials 4633 4634 +1 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| /** Draws the symbol for a single entity. Checks visibility in double blind. */ | ||
| private void paintSensor(Graphics g, Entity entity) { | ||
| if (EntityVisibilityUtils.onlyDetectedBySensors(client.getLocalPlayer(), entity)) { |
Check warning
Code scanning / CodeQL
Dereferenced variable may be null Warning
Scoppio
added
GUI
Scoppio
commented
Jan 27, 2025
megamek/src/megamek/client/ui/swing/minimap/BoardviewlessMinimap.java
Outdated
Show resolved
Hide resolved
Sleet01
reviewed
Jan 28, 2025
| if (border) { | ||
| g.setColor(g.getColor().darker()); | ||
| } | ||
| // if (border) { |
Sleet01
requested changes
Jan 28, 2025
Scoppio
commented
Jan 29, 2025
4 tasks
Scoppio
commented
Jan 31, 2025
| @@ -2070,7 +2078,7 @@ public void setVisible(boolean visible) { | |||
| } | |||
| } | |||
|
|
|||
| minimapTheme.setSelectedItem(CLIENT_PREFERENCES.getMinimapTheme()); | |||
| minimapTheme.setSelectedItem(CLIENT_PREFERENCES.getMinimapTheme().getName()); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both options are available on the client options in the minimap tab, they are also accessible through the minimap right click contextual menu.
Example
Quirks
The external braket is half hex bigger, while the internal bracket is half hex smaller, so an 8-16 sensor is shown around 7.5 - 16.5