New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utility AI - framework and Editor [wip] #6323

Draft

Scoppio wants to merge 33 commits into MegaMek:master from Scoppio:feat/tinkering-princess-ai

Collaborator

Scoppio commented Dec 28, 2024 •

edited

Loading

Development of a Utility AI framework to be implemented with a bot (preferably on top of princess, preferably creating a new way to have her make decisions).

This PR currently only implements a few considerations and an AI Editor, this PR intends to allow people to test and evaluate the usability of the AI Editor.

TODO: More information on the Utility AI, how it works, how it integrates with Princessm etc.

codecov bot commented Dec 28, 2024 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.19%. Comparing base (77b532e) to head (c3228f0).
Report is 21 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #6323      +/-   ##
============================================
- Coverage     28.55%   28.19%   -0.37%     
- Complexity    14465    14506      +41     
============================================
  Files          2815     2881      +66     
  Lines        277311   281148    +3837     
  Branches      48973    49340     +367     
============================================
+ Hits          79175    79258      +83     
- Misses       193436   197169    +3733     
- Partials       4700     4721      +21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-advanced-security bot found potential problems

View reviewed changes

megamek/src/megamek/ai/utility/DecisionContext.java Fixed Show fixed Hide fixed

megamek/src/megamek/ai/utility/DecisionMaker.java Fixed Show fixed Hide fixed

megamek/src/megamek/ai/utility/Intelligence.java Fixed Show fixed Hide fixed

megamek/src/megamek/ai/utility/Intelligence.java Fixed Show fixed Hide fixed

megamek/src/megamek/ai/utility/LinearCurve.java Fixed Show fixed Hide fixed

megamek/src/megamek/ai/utility/LogitCurve.java Fixed Show fixed Hide fixed

megamek/src/megamek/ai/utility/ParabolicCurve.java Fixed Show fixed Hide fixed

megamek/src/megamek/client/bot/duchess/ai/utility/tw/TWUtilityAIRepository.java Fixed Show fixed Hide fixed

megamek/src/megamek/client/bot/duchess/ai/utility/tw/TWUtilityAIRepository.java Fixed Show fixed Hide fixed

megamek/src/megamek/client/ui/swing/ai/editor/ParametersTableModel.java Fixed Show fixed Hide fixed

Scoppio force-pushed the feat/tinkering-princess-ai branch from 82be31d to 572a2a2 Compare

December 30, 2024 02:30

github-advanced-security bot found potential problems

View reviewed changes

megamek/src/megamek/ai/utility/BandFilterCurve.java Fixed Show fixed Hide fixed

megamek/src/megamek/ai/utility/BandPassCurve.java Fixed Show fixed Hide fixed

megamek/src/megamek/ai/utility/Consideration.java Fixed Show fixed Hide fixed

megamek/src/megamek/ai/utility/DefaultCurve.java

+                  }
+                  public static DefaultCurve fromCurve(Curve curve) {
+                      if (curve instanceof LinearCurve) {

Check notice

Code scanning / CodeQL

Chain of 'instanceof' tests Note

This if block performs a chain of 6 type tests - consider alternatives, e.g. polymorphism or the visitor pattern.

megamek/src/megamek/ai/utility/LinearCurve.java Fixed Show fixed Hide fixed

megamek/src/megamek/ai/utility/LogisticCurve.java Fixed Show fixed Hide fixed

megamek/src/megamek/ai/utility/ParabolicCurve.java Fixed Show fixed Hide fixed

megamek/src/megamek/client/ui/swing/ai/editor/AiProfileEditor.java Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems

View reviewed changes

megamek/src/megamek/client/bot/duchess/ai/utility/tw/TWUtilityAIRepository.java Fixed Show fixed Hide fixed

This was referenced Dec 31, 2024

Feat/tinkering princess ai [wip] MegaMek/mekhq#5569

Draft

Feat/tinkering princess ai [wip] MegaMek/megameklab#1672

Draft

Scoppio self-assigned this

Scoppio force-pushed the feat/tinkering-princess-ai branch from 2f32e50 to 448b792 Compare

December 31, 2024 02:34

Scoppio added Princess/AI ACAR labels

github-advanced-security bot found potential problems

View reviewed changes

github-advanced-security bot left a comment

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

github-advanced-security bot found potential problems

View reviewed changes

megamek/src/megamek/client/bot/ChatProcessor.java

+                          var splitPosition = hex.length() / 2;
+                          int x = Integer.parseInt(hex.substring(0, splitPosition)) - 1;
+                          int y = Integer.parseInt(hex.substring(splitPosition)) - 1;

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note

Potential uncaught 'java.lang.NumberFormatException'.

megamek/src/megamek/client/bot/ChatProcessor.java


		int x = Integer.parseInt(hex.substring(0, splitPosition)) - 1;
		int y = Integer.parseInt(hex.substring(splitPosition)) - 1;

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note

Potential uncaught 'java.lang.NumberFormatException'.

megamek/src/megamek/client/bot/ChatProcessor.java

+                              return;
+                          }
+                          int unitID = Integer.parseInt(unitIdString);

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note

Potential uncaught 'java.lang.NumberFormatException'.

megamek/src/megamek/client/bot/ChatProcessor.java

+                              var splitPosition = hex.length() / 2;
+                              int x = Integer.parseInt(hex.substring(0, splitPosition)) - 1;
+                              int y = Integer.parseInt(hex.substring(splitPosition)) - 1;

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note

Potential uncaught 'java.lang.NumberFormatException'.

megamek/src/megamek/client/bot/ChatProcessor.java


		int x = Integer.parseInt(hex.substring(0, splitPosition)) - 1;
		int y = Integer.parseInt(hex.substring(splitPosition)) - 1;

Check notice

Code scanning / CodeQL

Missing catch of NumberFormatException Note

Potential uncaught 'java.lang.NumberFormatException'.

megamek/src/megamek/client/bot/queen/Queen.java Fixed Show fixed Hide fixed

megamek/src/megamek/client/bot/queen/ai/utility/tw/TWUtilityAIRepository.java Fixed Show fixed Hide fixed

megamek/src/megamek/client/bot/queen/ai/utility/tw/TWUtilityAIRepository.java Fixed Show fixed Hide fixed

megamek/src/megamek/client/bot/queen/ai/utility/tw/intelligence/SimpleIntelligence.java Fixed Show fixed Hide fixed

megamek/src/megamek/client/ui/swing/ai/editor/ConsiderationParametersTable.java Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems

View reviewed changes

megamek/src/megamek/ai/utility/DebugReporter.java

+                      return this;
+                  }
+                  public DebugReporter append(Object s) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method DebugReporter.append(..) could be confused with overloaded method

append

, since dispatch depends on static types.

megamek/src/megamek/ai/utility/DecisionScoreEvaluator.java

+                      return finalScore;
+                  }
+                  public List<Consideration<IN_GAME_OBJECT, TARGETABLE>> getConsiderations() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note

getConsiderations exposes the internal representation stored in field considerations. The value may be modified

after this call to getConsiderations

.

megamek/src/megamek/client/bot/queen/ai/utility/tw/decision/TWDecisionContext.java Fixed Show fixed Hide fixed

github-advanced-security bot found potential problems

View reviewed changes

megamek/src/megamek/ai/utility/Profile.java

+                      return id;
+                  }
+                  public List<Decision<A, B>> getDecisions() {

Check notice

Code scanning / CodeQL

Exposing internal representation Note

getDecisions exposes the internal representation stored in field decisions. The value may be modified

after this call to getDecisions

.

github-advanced-security bot found potential problems

View reviewed changes

megamek/src/megamek/ai/utility/Intelligence.java


		public interface Intelligence<IN_GAME_OBJECT, TARGETABLE, RANKED> {

		void update(Intelligence<IN_GAME_OBJECT, TARGETABLE, RANKED> intelligence);

Check notice

Code scanning / CodeQL

Useless parameter Note

The parameter 'intelligence' is never used.

HammerGS added the For New Dev Cycle label

Scoppio added 13 commits

February 3, 2025 22:47


          feat: removed a bunch of little warnings from princess

927c145


          feat: basis for AI editor, decision, dse, etc

b172070


          feat: curve graph working, multi hover graph working, AI editor halfw…

b78e849

…ay there


          feat: i18n the forms

b95689b


          feat: basic for bot

883fe65


          feat: small improvements on a couple of forms

ba8a591


          feat: added common menu bar, removed trash code

011eb67


          feat: AI Editor is half-way there

04611b2


          chore: update user data readme

8057d81


          fix: more random profile id

9b4558c


          feat: added new curves, added reflection based ui controls

f237e04


          feat: import and export ai files

c9da7f2


          feat: small improvements on internationalization

3dae019

Scoppio added 15 commits

February 3, 2025 22:54


          fix: fixed error where property k would show up twice for the deseria…

fca0201

…lizer


          feat: adding toolbar to DSE and Profile

7ee7174


          chore: removing comments that borked javadoc

8de920e


          feat: pilot base roll cached


          feat: implementing the simple intelligence and path ranker

5f74002


          chore: cleaning up chat processor

44f191b


          feat: changed hane from duchess to queen as it does not yet share str…

a5e8635

…ategies together


          feat: updating UI to not have to rely on intelliJ layout

478a507


          feat: new considerations, revamping editor

83b8eca


          feat: adding facing arrows and sensor range to boardviewlessminimap

ba191a8


          fix: making the AI Editor actually work

52d7b3c


          feat: ai work, changing string builder for log traces

ba24506


          fix: small fixes for the current version

bd019ed


          Delete .github/copilot-instructions.md

038962c


          feat: multiple additions for testing things

918cfca

Scoppio force-pushed the feat/tinkering-princess-ai branch from 3864b40 to 918cfca Compare

February 4, 2025 02:59

github-advanced-security bot found potential problems

View reviewed changes

megamek/src/megamek/client/bot/caspar/Caspar.java Fixed Show fixed Hide fixed

megamek/src/megamek/client/bot/princess/BasicPathRanker.java Fixed Show fixed Hide fixed

megamek/unittests/megamek/logging/MMLoggerTest.java

+                  public void testErrorLoggingWithExceptionNoParams() {
+                      automaticallyDismissDialog();
+                      Exception e = new Exception("Test exception");
+                      testMMLogger.error(e, "Error message: noparameter accepted", "test");

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation Note

Invoking

MMLogger.error

should be avoided because it has been deprecated.

megamek/unittests/megamek/logging/MMLoggerTest.java

+                      }
+                      @Override
+                      public boolean isEnabled(Level level, Marker marker, String message, Object p0) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method CustomLogger.isEnabled(..) could be confused with overloaded method

isEnabled

, since dispatch depends on static types.
Method CustomLogger.isEnabled(..) could be confused with overloaded method

isEnabled

, since dispatch depends on static types.

megamek/unittests/megamek/logging/MMLoggerTest.java

+                      }
+                      @Override
+                      public boolean isEnabled(Level level, org.apache.logging.log4j.Marker marker, Object message, Throwable t) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method CustomLogger.isEnabled(..) could be confused with overloaded method

isEnabled

, since dispatch depends on static types.
Method CustomLogger.isEnabled(..) could be confused with overloaded method

isEnabled

, since dispatch depends on static types.
Method CustomLogger.isEnabled(..) could be confused with overloaded method

isEnabled

, since dispatch depends on static types.

megamek/unittests/megamek/logging/MMLoggerTest.java

+                      }
+                      @Override
+                      public boolean isEnabled(Level level, Marker marker, CharSequence message, Throwable t) {

Check notice

Code scanning / CodeQL

Confusing overloading of methods Note

Method CustomLogger.isEnabled(..) could be confused with overloaded method

isEnabled

, since dispatch depends on static types.
Method CustomLogger.isEnabled(..) could be confused with overloaded method

isEnabled

, since dispatch depends on static types.
Method CustomLogger.isEnabled(..) could be confused with overloaded method

isEnabled

, since dispatch depends on static types.

Scoppio force-pushed the feat/tinkering-princess-ai branch 4 times, most recently from 04d846a to 54b383d Compare

February 4, 2025 04:01


          fix: merge conflict

91ee7b2

Scoppio force-pushed the feat/tinkering-princess-ai branch from 54b383d to 91ee7b2 Compare

February 4, 2025 04:02

Scoppio added 4 commits

February 4, 2025 20:09


          fix: path ranker

2e39ca2


          Merge branch 'master' into feat/tinkering-princess-ai

6399ba6


          Merge branch 'master' into feat/tinkering-princess-ai

7b4a8f0


          fix: adding missing overrides

c3228f0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ACAR For New Dev Cycle Princess/AI