Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two talon bugs #2503

Merged
merged 3 commits into from
Dec 12, 2020
Merged

Two talon bugs #2503

merged 3 commits into from
Dec 12, 2020

Conversation

neoancient
Copy link
Member

This fixes two bugs with loading and validating mechs with talons:

  1. Superheavies only require one slot in each leg for talons.
  2. During post-load init, anything that is not a biped or quad is treated as a non-mech, which results in tripod mechs with talons throwing an EntityLoadingException.

Fixes MegaMek/megameklab#844

sixlettervariables
sixlettervariables approved these changes Dec 12, 2020
View reviewed changes
Copy link
Contributor

@sixlettervariables sixlettervariables left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor text update needed, otherwise looks good!

megamek/src/megamek/common/verifier/TestMech.java Outdated Show resolved Hide resolved
@neoancient neoancient merged commit 7708064 into master Dec 12, 2020
@neoancient neoancient deleted the superheavy_talons branch December 12, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sixlettervariables sixlettervariables sixlettervariables approved these changes

@Windchild292 Windchild292 Windchild292 approved these changes

@NickAragua NickAragua Awaiting requested review from NickAragua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Talons not handled correctly for superheavies or tripods
3 participants
@neoancient @sixlettervariables @Windchild292