Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix finish_reason #92

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Fix finish_reason #92

merged 1 commit into from
Jan 17, 2024

Conversation

jeffreymeetkai
Copy link
Collaborator

If user provides tools instead of functions for v1,

  • Change all function_calls to tool_calls for both streaming and non-streaming
  • Fix finish_reason from function_call to tool_calls for both streaming and non-streaming

For v2,

  • tool_calls will always be generated regardless whether user passes in tools or functions

@jeffreymeetkai jeffreymeetkai merged commit 71cdd25 into main Jan 17, 2024
3 checks passed
@jeffreymeetkai jeffreymeetkai deleted the fix-finish-reason branch November 6, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musab-mk musab-mk musab-mk approved these changes

@khai-meetkai khai-meetkai Awaiting requested review from khai-meetkai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffreymeetkai @musab-mk