Fix for "interesting" SPLIT + GROUP issue. #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found by Torben R. Nielsen: An instrument with SPLIT and a subsequent GROUP of monitors would "lose intensity" and events. After a long analysis with Erik we found that this was due to use of ABSORB; in the final GROUP member (but in the raytrace function) yet still meaning exit(). Hence, non-scattered neutrons (or e.g. n'th pass of the SPLIT) would always exit not only the group, but the full raytrace() fct.
|
All checks OK, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by Torben R. Nielsen: An instrument with SPLIT and a subsequent GROUP of monitors would "lose intensity" and events. After a long analysis with Erik we found that this was due to use of ABSORB; in the final GROUP member (but in the raytrace function) yet still meaning exit().
Hence, non-scattered neutrons (or e.g. n'th pass of the SPLIT) would always exit not only the group, but the full raytrace() fct.