Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of mcpl_dump() in both McStas and McXtrace MCPL_output verbose mode #1704

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

willend
Copy link
Contributor

@willend willend commented Sep 20, 2024

Sync McStas<->McXtrace MCPL_output.comp and use mcpl_dump() function to give a result summary

@willend willend requested a review from g5t September 20, 2024 10:28
@willend
Copy link
Contributor Author

willend commented Sep 20, 2024

@g5t as per our chat.

@g5t
Copy link
Contributor

g5t commented Sep 20, 2024

Other than potentially exposing the mcpl_dump settings, this looks OK to me.
(I'm assuming that you copied from the McStas to McXtrace component correctly, and haven't checked it in detail)

@willend
Copy link
Contributor Author

willend commented Sep 20, 2024

I have run local tests myself via the Test_MCPL_output instruments. And this little change is certainly better than the previous hack, calling mcpltool via a system call.

@willend willend merged commit b32e8ea into McStasMcXtrace:main Sep 20, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants