Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining prefixes to logger on important files #1255

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Add remaining prefixes to logger on important files #1255

merged 4 commits into from
Nov 27, 2024

Conversation

melroy89
Copy link
Member

@melroy89 melroy89 commented Nov 27, 2024 •
edited
Loading

I also like this prefix and let's make it a best practice.

  • Try to be consistent now
  • Added prefix to logger to the most important files
  • Added to debug, info, warning and error (and fatal if we had it :P)

@melroy89 melroy89 added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 27, 2024
@melroy89 melroy89 changed the title Add remaining fixes to logger on important files Add remaining prefixes to logger on important files Nov 27, 2024
@melroy89 melroy89 enabled auto-merge (squash) November 27, 2024 23:16
@melroy89 melroy89 merged commit 8f7b0ba into main Nov 27, 2024
7 checks passed
@melroy89 melroy89 deleted the add_missing_prefix_to_logs branch November 27, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BentiGorlich BentiGorlich BentiGorlich approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@melroy89 @BentiGorlich