Test TLS connections in Mbed TLS 3.6.0 without psa_crypto_init #9215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revise the PSA initialization for TLS with respect to TLS 1.3 enablement. For backward compatibility with Mbed TLS < 3.6.0, in the default compile-time configuration, users do not need to call psa_crypto_init() unless they have taken some affirmative step to enable TLS 1.3 support. Mbed TLS changed the default compile-time configuration to enable TLS 1.3 support by default (MBEDTLS_SSL_PROTO_TLS1_3 enabled by default), but users are free to ignore that. In Mbed TLS 3.6.0, as soon as MBEDTLS_SSL_PROTO_TLS1_3 is enabled, users need to call psa_crypto_init() before starting a TLS connection that may use TLS 1.3. This commit makes this call explicit. Later commits will adjust the conditions of this call to skip it when mimicking a user of Mbed TLS <3.6 who did not cal psa_crypto_init(). Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
needs-work
component-tls
needs-ci
|
Superseded by #9501. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Mbed TLS 3.6.0 in the default configuration, and not calling
psa_crypto_init(), TLS connections fail if they end up negotiating TLS 1.3. See #9210.Status: work in progress — I'm setting up some testing. This is just at the proof-of-concept stage for now: the final form will depend both on how the tests evolve and how we decide to fix the library. My plan:
ssl_client2/ssl_server2), callpsa_crypto_initonly when needed according to the documentation (including Mbed TLS 3.5 documentation, for backward compatibility). This will cause some test failures in the default configuration when we end up negotiating TLS 1.3 without having calledpsa_crypto_init.PR checklist