[MBEDTLS_PRIVATE] Add accessor for session and ciphersuite_id #8888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
Signed-off-by: Minos Galanakis <[email protected]>
minosgalanakis
added
needs-ci
minosgalanakis
force-pushed
the
features/add_ssl_session_accessor_8529
branch
5 times, most recently
from
0ad9589 to
a058c4e
Compare
Signed-off-by: Minos Galanakis <[email protected]>
minosgalanakis
force-pushed
the
features/add_ssl_session_accessor_8529
branch
2 times, most recently
from
417517f to
32426cb
Compare
minosgalanakis
added
needs-review
minosgalanakis
commented
Mar 7, 2024
|
|
||
| /* Test setting a reference id for tls1.3 and tls1.2 */ | ||
| ciphersuite_info = mbedtls_ssl_ciphersuite_from_id(ciphersuite_id); | ||
| if (ciphersuite_info != NULL) { |
There was a problem hiding this comment.
In certain configurations the ssl_ciphersuite_from_id will return NULL. Testing this function is outside of the scope so we only test the getter for the other cases where it will create a ciphersuite_info stucture.
davidhorstmann-arm
requested changes
Mar 7, 2024
tom-daubney-arm
removed
the
needs-reviewer
minosgalanakis
force-pushed
the
features/add_ssl_session_accessor_8529
branch
from
32426cb to
0338122
Compare
davidhorstmann-arm
previously approved these changes
Mar 7, 2024
tom-daubney-arm
requested changes
Mar 8, 2024
tests/suites/test_suite_ssl.data
Outdated
| @@ -961,6 +961,14 @@ TLS 1.3: SRV: session serialization: Wrong config | |||
| depends_on:MBEDTLS_SSL_PROTO_TLS1_3:MBEDTLS_SSL_SRV_C | |||
| ssl_session_serialize_version_check:0:0:0:1:MBEDTLS_SSL_IS_SERVER:MBEDTLS_SSL_VERSION_TLS1_3 | |||
|
|
|||
| Test Session id & Ciphersuite accesors TLS 1.2 | |||
There was a problem hiding this comment.
Suggested change
| Test Session id & Ciphersuite accesors TLS 1.2 | |
| Test Session id & Ciphersuite accessors TLS 1.2 |
tests/suites/test_suite_ssl.data
Outdated
| depends_on:MBEDTLS_SSL_PROTO_TLS1_2 | ||
| ssl_session_id_accessors_check:MBEDTLS_SSL_VERSION_TLS1_2 | ||
|
|
||
| Test Session id & Ciphersuite accesors TLS 1.3 |
There was a problem hiding this comment.
Suggested change
| Test Session id & Ciphersuite accesors TLS 1.3 | |
| Test Session id & Ciphersuite accessors TLS 1.3 |
Signed-off-by: Minos Galanakis <[email protected]>
minosgalanakis
force-pushed
the
features/add_ssl_session_accessor_8529
branch
from
0338122 to
f9a6893
Compare
minosgalanakis
added
priority-very-high
tom-daubney-arm
approved these changes
Mar 11, 2024
davidhorstmann-arm
approved these changes
Mar 12, 2024
tom-daubney-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ps is adding accessors for the following members of the
mbedtls_ssl_sessionint MBEDTLS_PRIVATE(ciphersuite)->mbedtls_ssl_session_get_ciphersuite_id()size_t MBEDTLS_PRIVATE(id_len)->mbedtls_ssl_session_get_id_len()-
unsigned char MBEDTLS_PRIVATE(id)[32->mbedtls_ssl_session_get_id()As well as one accessor for the
mbedtls_ssl_ciphersuite_tstructuint8_t MBEDTLS_PRIVATE(cipher)->mbedtls_ssl_ciphersuite_get_id()Resolves #8529
PR checklist
Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")