Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MBEDTLS_PRIVATE] Update dhm context in programs #8702

Merged
merged 3 commits into from
Feb 10, 2024
Merged

[MBEDTLS_PRIVATE] Update dhm context in programs #8702

merged 3 commits into from
Feb 10, 2024

Conversation

minosgalanakis
Copy link
Contributor

Description

This PR replaces the legacy MBEDTLS_PRIVATE directly accessed fields with API calls.

Resolves #5015

PR checklist

Please tick as appropriate and edit the reasons (e.g.: "backport: not needed because this is a new feature")

  • changelog Not required, does not modify the library, just the reference programs.
  • backport Not required, this is MBEDTLS 3.X specific.
  • tests Not required, only changes test programs.

@minosgalanakis minosgalanakis added needs-ci Needs to pass CI tests needs-preceding-pr Requires another PR to be merged first size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon labels Jan 15, 2024
@minosgalanakis minosgalanakis force-pushed the update/dhm_context_in_programs_5015 branch 3 times, most recently from 72cd92c to 5817a53 Compare January 19, 2024 17:00
@minosgalanakis minosgalanakis force-pushed the update/dhm_context_in_programs_5015 branch from 5817a53 to 8ee1b5f Compare January 26, 2024 15:00
@minosgalanakis minosgalanakis added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-preceding-pr Requires another PR to be merged first labels Jan 26, 2024
@minosgalanakis minosgalanakis removed the needs-ci Needs to pass CI tests label Feb 6, 2024
mpg
mpg approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgonzalezorlandoarm tgonzalezorlandoarm removed the needs-reviewer This PR needs someone to pick it up for review label Feb 9, 2024
tgonzalezorlandoarm
tgonzalezorlandoarm approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@tgonzalezorlandoarm tgonzalezorlandoarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@minosgalanakis minosgalanakis added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Feb 9, 2024
@mpg mpg added this pull request to the merge queue Feb 10, 2024
Merged via the queue into Mbed-TLS:development with commit c3d17cd Feb 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpg mpg mpg approved these changes

@tgonzalezorlandoarm tgonzalezorlandoarm tgonzalezorlandoarm approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace the the private field acces of mbedtls_dhm_context with APIs
3 participants
@minosgalanakis @mpg @tgonzalezorlandoarm