-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Windows APIs that are banned in Windows Store apps #730
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,28 +54,41 @@ | |
#define _WIN32_WINNT 0x0400 | ||
#endif | ||
#include <windows.h> | ||
#include <wincrypt.h> | ||
#include <bcrypt.h> | ||
#if _MSC_VER <= 1600 | ||
/* Visual Studio 2010 and earlier issue a warning when both <stdint.h> and <intsafe.h> are included, as they | ||
* redefine a number of <TYPE>_MAX constants. These constants are guaranteed to be the same, though, so | ||
* we suppress the warning when including intsafe.h. | ||
*/ | ||
#pragma warning( push ) | ||
#pragma warning( disable : 4005 ) | ||
#endif | ||
#include <intsafe.h> | ||
#if _MSC_VER <= 1600 | ||
#pragma warning( pop ) | ||
#endif | ||
|
||
int mbedtls_platform_entropy_poll( void *data, unsigned char *output, size_t len, | ||
size_t *olen ) | ||
{ | ||
HCRYPTPROV provider; | ||
ULONG len_as_ulong = 0; | ||
((void) data); | ||
*olen = 0; | ||
|
||
if( CryptAcquireContext( &provider, NULL, NULL, | ||
PROV_RSA_FULL, CRYPT_VERIFYCONTEXT ) == FALSE ) | ||
/* | ||
* BCryptGenRandom takes ULONG for size, which is smaller than size_t on 64-bit platforms. | ||
* Ensure len's value can be safely converted into a ULONG. | ||
*/ | ||
if ( FAILED( SizeTToULong( len, &len_as_ulong ) ) ) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
{ | ||
return( MBEDTLS_ERR_ENTROPY_SOURCE_FAILED ); | ||
} | ||
|
||
if( CryptGenRandom( provider, (DWORD) len, output ) == FALSE ) | ||
if ( !BCRYPT_SUCCESS( BCryptGenRandom( NULL, output, len_as_ulong, BCRYPT_USE_SYSTEM_PREFERRED_RNG ) ) ) | ||
{ | ||
CryptReleaseContext( provider, 0 ); | ||
return( MBEDTLS_ERR_ENTROPY_SOURCE_FAILED ); | ||
} | ||
|
||
CryptReleaseContext( provider, 0 ); | ||
*olen = len; | ||
|
||
return( 0 ); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,6 +62,18 @@ | |
|
||
#if defined(_WIN32) && !defined(EFIX64) && !defined(EFI32) | ||
#include <windows.h> | ||
#if _MSC_VER <= 1600 | ||
/* Visual Studio 2010 and earlier issue a warning when both <stdint.h> and <intsafe.h> are included, as they | ||
* redefine a number of <TYPE>_MAX constants. These constants are guaranteed to be the same, though, so | ||
* we suppress the warning when including intsafe.h. | ||
*/ | ||
#pragma warning( push ) | ||
#pragma warning( disable : 4005 ) | ||
#endif | ||
#include <intsafe.h> | ||
#if _MSC_VER <= 1600 | ||
#pragma warning( pop ) | ||
#endif | ||
#else | ||
#include <time.h> | ||
#endif | ||
|
@@ -1108,6 +1120,7 @@ int mbedtls_x509_crt_parse_path( mbedtls_x509_crt *chain, const char *path ) | |
char filename[MAX_PATH]; | ||
char *p; | ||
size_t len = strlen( path ); | ||
int lengthAsInt = 0; | ||
|
||
WIN32_FIND_DATAW file_data; | ||
HANDLE hFind; | ||
|
@@ -1122,7 +1135,10 @@ int mbedtls_x509_crt_parse_path( mbedtls_x509_crt *chain, const char *path ) | |
p = filename + len; | ||
filename[len++] = '*'; | ||
|
||
w_ret = MultiByteToWideChar( CP_ACP, 0, filename, (int)len, szDir, | ||
if ( FAILED ( SizeTToInt( len, &lengthAsInt ) ) ) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
return( MBEDTLS_ERR_X509_FILE_IO_ERROR ); | ||
|
||
w_ret = MultiByteToWideChar( CP_ACP, 0, filename, lengthAsInt, szDir, | ||
MAX_PATH - 3 ); | ||
if( w_ret == 0 ) | ||
return( MBEDTLS_ERR_X509_BAD_INPUT_DATA ); | ||
|
@@ -1139,8 +1155,11 @@ int mbedtls_x509_crt_parse_path( mbedtls_x509_crt *chain, const char *path ) | |
if( file_data.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY ) | ||
continue; | ||
|
||
if ( FAILED( SizeTToInt( wcslen( file_data.cFileName ), &lengthAsInt ) ) ) | ||
return( MBEDTLS_ERR_X509_FILE_IO_ERROR ); | ||
|
||
w_ret = WideCharToMultiByte( CP_ACP, 0, file_data.cFileName, | ||
lstrlenW( file_data.cFileName ), | ||
lengthAsInt, | ||
p, (int) len - 1, | ||
NULL, NULL ); | ||
if( w_ret == 0 ) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole block including the
#if _MSC_VER <= 1600
checks, the#pragma
s and the inclusion ofintsafe.h
are specific to Visual Studio, so it needs to be protected by#if defined(_MSC_VER)
. Otherwise this breaks the build with MinGW. The same goes for the similar block of code inx509_crt.c
.