Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport 2.28: Enable mpi_mod_int test case to take full-range MPI integers #6575

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Backport 2.28: Enable mpi_mod_int test case to take full-range MPI integers #6575

merged 3 commits into from
Nov 14, 2022

Conversation

tom-cosgrove-arm
Copy link
Contributor

@tom-cosgrove-arm tom-cosgrove-arm commented Nov 9, 2022 •
edited by yanesca
Loading

Backport of #6573

Gatekeeper checklist

  • changelog not required - this is tests
  • backport - this is the backport
  • tests these are tests

This was referenced Nov 9, 2022
Merged
Open
@wernerlewis wernerlewis added component-crypto Crypto primitives and low-level interfaces needs-ci Needs to pass CI tests size-s Estimated task size: small (~2d) priority-medium Medium priority - this can be reviewed as time permits labels Nov 9, 2022
wernerlewis
wernerlewis previously approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@wernerlewis wernerlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, faithful backport

@wernerlewis wernerlewis added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-ci Needs to pass CI tests labels Nov 9, 2022
@gilles-peskine-arm gilles-peskine-arm self-requested a review November 9, 2022 17:43
@gilles-peskine-arm gilles-peskine-arm removed the needs-reviewer This PR needs someone to pick it up for review label Nov 9, 2022
gilles-peskine-arm
gilles-peskine-arm previously approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We should backport the renaming of the test functions to make backports like this one easier.

wernerlewis
wernerlewis previously approved these changes Nov 10, 2022
View reviewed changes
@gilles-peskine-arm
Copy link
Contributor

Please rebase with the renamed test suite — sorry. Git seems to cope with a rebase without assistance, but can't figure out a merge.

@gilles-peskine-arm gilles-peskine-arm added needs-work and removed needs-review Every commit must be reviewed by at least two team members, labels Nov 10, 2022
@tom-cosgrove-arm tom-cosgrove-arm force-pushed the convert-mpi_mod_int-test-cases-to-hex-228 branch from d1f8c76 to 020ab7f Compare November 10, 2022 16:23
@tom-cosgrove-arm tom-cosgrove-arm added needs-review Every commit must be reviewed by at least two team members, and removed needs-work labels Nov 10, 2022
gilles-peskine-arm
gilles-peskine-arm approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilles-peskine-arm gilles-peskine-arm added approved Design and code approved - may be waiting for CI or backports needs-ci Needs to pass CI tests single-reviewer This PR qualifies for having only one reviewer labels Nov 10, 2022
@tom-cosgrove-arm
Copy link
Contributor Author

CI has passed, so removing needs-ci

@tom-cosgrove-arm tom-cosgrove-arm removed the needs-ci Needs to pass CI tests label Nov 11, 2022
@yanesca yanesca merged commit 5c03ec3 into Mbed-TLS:mbedtls-2.28 Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilles-peskine-arm gilles-peskine-arm gilles-peskine-arm approved these changes

@wernerlewis wernerlewis Awaiting requested review from wernerlewis

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports component-crypto Crypto primitives and low-level interfaces needs-review Every commit must be reviewed by at least two team members, priority-medium Medium priority - this can be reviewed as time permits single-reviewer This PR qualifies for having only one reviewer size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tom-cosgrove-arm @gilles-peskine-arm @wernerlewis @yanesca