Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all.sh: Require i686-w64-mingw32-gcc version >= 6 #2586

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

Patater
Copy link
Contributor

@Patater Patater commented Apr 17, 2019

Require mingw gcc version 6 or greater in order to ensure
BCryptGenRandom() is available.

This should enable #1453 to pass CI after it is rebased.

Along with merging this PR, CI must be updated to run all.sh's mingw64 job on a supported platform, like Ubuntu 18.04.

Status

READY

Requires Backporting

NO - LTS branches don't depend on BCryptGenRandom(), so they can run mingw tests fine with older gcc.

Migrations

NO

Require mingw gcc version 6 or greater in order to ensure
BCryptGenRandom() is available.
@Patater Patater added enhancement mbed TLS team needs-review Every commit must be reviewed by at least two team members, component-platform Portability layer and build scripts needs-ci Needs to pass CI tests labels Apr 17, 2019
@Patater Patater requested a review from dgreen-arm April 18, 2019 08:22
Copy link
Contributor

@dgreen-arm dgreen-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Patater Patater removed the needs-ci Needs to pass CI tests label Apr 18, 2019
@Patater Patater requested a review from k-stachowiak April 18, 2019 12:03
@Patater Patater added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Apr 18, 2019
@Patater Patater merged commit 117b8a4 into Mbed-TLS:development Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports component-platform Portability layer and build scripts enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants