refactor: Refactor collections for better performance, readability, and maintainability #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MSDarwish2000
commented
Dec 4, 2024
MSDarwish2000
commented
- refactor: Remove not needed ObjectList and its related code
- refactor: Update ScatterMap to latest commit without modifications
- refactor: Apply required changes to ScatterMap
- refactor: Refactor collections for easier-to-maintain code
MSDarwish2000
force-pushed
the
refactor/collections
branch
3 times, most recently
from
ae3baac to
388ea7c
Compare
Signed-off-by: Mohamed Darwish <[email protected]>
Latest commit is b63ae48 (2024-11-08 2:47 PST) Signed-off-by: Mohamed Darwish <[email protected]>
The changes include: - Renaming package to `com.mayakapps.kache.collection`. - Setting top-level declarations visibility to internal. - Adding dummy @PublishedApi to avoid exposing internal code - Removing functions that accept `ScatterSet` and `ObjectList` and their tests as these types are not included or needed. - Add `keySet` property to `ScatterMap`. - Add `onAccess()` to `ScatterMap` and `onInsertion()`, `onReplacement()`, and `onRemoval()` to `MutableScatterMap` with appropriate calls to them. - Make `forEachIndexed()` use the chain if the map is `MutableChainedScatterMap`. - Increase `initializeStorage()` and `findFirstAvailableSlot()` visibility to be called from `MutableChainedScatterMap.resizeStorage()`. - Open `MutableScatterMap`, `clear()`, and `resizeStorage()` to inheritance. Signed-off-by: Mohamed Darwish <[email protected]>
Signed-off-by: Mohamed Darwish <[email protected]>
MSDarwish2000
force-pushed
the
refactor/collections
branch
from
388ea7c to
5e1a062
Compare
Signed-off-by: Mohamed Darwish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.