Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide buttons when logged out #849

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

notama-nr2527
Copy link

When loggd out: Hide "Add Data Class" and "Add Rule" & "Export" buttons;
hide "Add Terms" & "Add Relationship Type" buttons, as well as the icons
for rule editing.
The buttons already do nothing since the object they changed is not
accesssible when logged out. Thus, we prevent a spurious error message
to be shown.

Apply Welch's suggestions: add canEdit boolean and fill it apropriately.
Before, we were blindly following the loggedIn status; now we also follow
backend's hints/permissions of whether we should show the button, in
addition to checking if the user is logged in.

Pedro Francisco added 2 commits March 8, 2024 12:02
…ons;

 hide "Add Terms" & "Add Relationship Type" buttons, as well as the icons
 for rule editing.

The buttons already do nothing since the object they changed is not
 accesssible when logged out. Thus, we prevent a spurious error message
 to be shown.
 Before, we were blindly following the loggedIn status; now we also follow
 backend's hints/permissions of whether we should show the button, in
 addition to checking if the user is logged in.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Pedro Francisco seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants