Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-389 Update SummaryMetadata to support filtering for index queries #390

Merged
merged 1 commit into from
Feb 6, 2023
Merged

gh-389 Update SummaryMetadata to support filtering for index queries #390

merged 1 commit into from
Feb 6, 2023

Conversation

pjmonks
Copy link
Contributor

@pjmonks pjmonks commented Jan 31, 2023

Also created tests for filtering/sorting summaryMetadata.

Following endpoints now supported:

GET /{domainType}/{id}/summaryMetadata?label=<value>

GET /{domainType}/{id}/summaryMetadata?sort=label&order=desc

Fixes #389

@pjmonks
gh-389 Update SummaryMetadata to support filtering for index queries
c83e9dd 
Also created tests for filtering/sorting summaryMetadata
@pjmonks pjmonks mentioned this pull request Jan 31, 2023
Merged
jamesrwelch
jamesrwelch approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@jamesrwelch jamesrwelch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One failing test, but it's unrelated. I've had a good play with this functionality, in combination with the PR in UI, and it all seems to work nicely. Nice one!

@jamesrwelch jamesrwelch removed the request for review from joe-crawford February 6, 2023 12:15
@jamesrwelch jamesrwelch merged commit f96d322 into develop Feb 6, 2023
@jamesrwelch jamesrwelch deleted the feature/gh-389 branch February 6, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesrwelch jamesrwelch jamesrwelch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
MDM State
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Have Summary Metadata support filtering and sorting
2 participants
@pjmonks @jamesrwelch