Delete BreadcrumbTree rows when parent Model is deleted #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add migration SQL to clear invalid core.breadcrumb_tree rows
…dcrumbs (gh-350) - Change these tests to functional tests from integration tests to work around issue with session rollback.
|
Failing test on PR build is unrelated. Have stopped the branch build to save time. |
jamesrwelch
approved these changes
Aug 6, 2022
|
Thanks @jamesrwelch ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-350.
Previously when deleting ReferenceDataModels and CodeSets, their child BreadcrumbTrees were deleted, but for DataModels and Terminologies only the top level BreadcrumbTree row was deleted. Add child BreadcrumbTree rows to multiple delete SQL and add clean-up migration SQL.