Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up unused endpoints #294

Merged
merged 3 commits into from
Mar 17, 2022
Merged

Clean up unused endpoints #294

merged 3 commits into from
Mar 17, 2022

Conversation

joe-crawford
Copy link
Contributor

Also:

  • Ensure tests use assertions where needed

@joe-crawford
gh-272 Remove unused clean datatypes/dataclasses endpoints
7230fd4 
- Delete dataTypes/clean and dataClasses/clean endpoints and controllers from datamodel plugin (resolves gh-272 error due to permissions)
- Delete dataTypes/clean endpoint and controller from referencedata plugin (endpoint gave error due to mapping issue)
@joe-crawford
gh-259 Delete unused keep alive endpoint
eef9c38
@joe-crawford
Add explicit assertions to some tests
6dcc598
@joe-crawford joe-crawford marked this pull request as draft March 16, 2022 14:41
@joe-crawford
Copy link
Contributor Author

VersionedFolderFunctionalSpec test failures look unrelated.

@joe-crawford joe-crawford marked this pull request as ready for review March 16, 2022 16:31
@olliefreeman olliefreeman merged commit 19432ea into develop Mar 17, 2022
@olliefreeman olliefreeman deleted the feature/bug-fixing-branch branch March 17, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olliefreeman olliefreeman olliefreeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@joe-crawford @olliefreeman