-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/gh 178 #194
Feature/gh 178 #194
Conversation
i will review this next week....theres a lot going on and i need to sit and work through it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes but the logic all looks good
- I have historically used the package
rest.transport
for defining command objects/pogos for binding data in and out of rest json. - the _profileProvided.gson should be in /profileProvided/_profileProvided.gson so that grails can auto find it as any class can be found this way where the template is in the folder with that class name. It allows grails to handle any fallback of rendering to use the template we want not a default object template
...n-profile/grails-app/controllers/uk/ac/ox/softeng/maurodatamapper/profile/UrlMappings.groovy
Outdated
Show resolved
Hide resolved
...ile/grails-app/controllers/uk/ac/ox/softeng/maurodatamapper/profile/ProfileController.groovy
Show resolved
Hide resolved
...ile/grails-app/controllers/uk/ac/ox/softeng/maurodatamapper/profile/ProfileController.groovy
Outdated
Show resolved
Hide resolved
...ile/grails-app/controllers/uk/ac/ox/softeng/maurodatamapper/profile/ProfileController.groovy
Show resolved
Hide resolved
...ile/grails-app/controllers/uk/ac/ox/softeng/maurodatamapper/profile/ProfileController.groovy
Outdated
Show resolved
Hide resolved
...ile/grails-app/controllers/uk/ac/ox/softeng/maurodatamapper/profile/ProfileController.groovy
Outdated
Show resolved
Hide resolved
...ile/grails-app/controllers/uk/ac/ox/softeng/maurodatamapper/profile/ProfileController.groovy
Outdated
Show resolved
Hide resolved
…d tests for this.
…to rest.transport
…related to command objects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the updated comments on the unresolved issues
… for these. Return not found for model not found, return bad request if object found is not a model.
Add endpoints for bulk retrieval and edit of many profiles against many data elements of a data model.
There are examples of the POST bodies added to the postman-library (separate PR).
Although the examples above are for data model, and this PR includes tests for data model, I would expect it also to work for the general case of retrieving and editing profiles against many model items of a model.
The deprecated MapBasedProfile has been removed.
Because the change requires retrieval or save of many resources in one request, this PR includes a slightly new pattern in that most security checks are done in the ProfileController rather than ProfileInterceptor. The pattern in the ProfileController is: