Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-171 Fix for folder search to include nested folders #190

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

GBishop-PHSA
Copy link
Contributor

No description provided.

Copy link
Contributor

@olliefreeman olliefreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer it if the base folder which all the test use is not a sub folder.
It just means we dont need to worry about hierarchy during testing some of the more basic concepts. However i guess this setup should highlight any issues earlier

@olliefreeman
Copy link
Contributor

@GBishop-PHSA can you add a brief description to the PR in the future. And also make sure any issues the PR resolves are also linked. We're using the GH built in doc generation for release notes and it uses issues and PR descriptions and names to provide info

@olliefreeman olliefreeman merged commit 56ad1d4 into MauroDataMapper:develop Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search does not work when user selects a folder in the Advanced options
2 participants