Temporarily disable subscribed model federate endpoint #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
joe-crawford
commented
Nov 2, 2021
joe-crawford
commented
- Return empty 200 status from /federate endpoint to prevent UI error when subscribing to model
- This makes the 'Synchronise' button in the UI not do anything (previously errored)
- To be reviewed as part of MC-9726
|
(Failing branch tests don't seem related.) |
olliefreeman
approved these changes
Nov 2, 2021
|
this is okay and failures are not related, however @joe-crawford please remember the required workflow,
|
|
@olliefreeman, I did wait until the branch build finished before opening PR, I think if it fails it still appears in the PR. |
- Return empty 200 status from /federate endpoint to prevent UI error when subscribing to model - This makes the 'Synchronise' button in the UI not do anything (previously errored) - To be reviewed as part of MC-9726
olliefreeman
force-pushed
the
feature/mc-9726
branch
from
9c94b36 to
0ca873d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.