Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'/profiles/otherMetadata' endpoint not filtering #180

Closed
jamesrwelch opened this issue Nov 9, 2021 · 1 comment · Fixed by #202
Closed

'/profiles/otherMetadata' endpoint not filtering #180

jamesrwelch opened this issue Nov 9, 2021 · 1 comment · Fixed by #202
Assignees
@aaronforshaw
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
5.0.0

Comments

@jamesrwelch
Copy link
Contributor

The /profiles/otherMetadata should be filterable with params ns, key, and value. But this isn't working - the back-end is not applying the filters correctly.
This needs fixing , and a test or two writing so that it doesn't break in the future.
@jamesrwelch jamesrwelch added bug Something isn't working good first issue Good for newcomers labels Nov 9, 2021
@olliefreeman
Copy link
Contributor

olliefreeman commented Nov 9, 2021 •
edited
Loading

The issue here is that the ui swoped from
Using the metadata endpoint which did filter and sort to the new “otherMetadata” endpoint which was never coded to use the filtering methods.

the fix is to look at “listAllReadableResources” in the metadata controller and apply the appropriate static methods used there to the otherMetadata method in the profile controller

@aaronforshaw aaronforshaw self-assigned this Nov 26, 2021
aaronforshaw added a commit that referenced this issue Nov 26, 2021
@aaronforshaw
gh-180 add filtering by namespace (ns), key and value
58bace3
@aaronforshaw aaronforshaw mentioned this issue Nov 26, 2021
Merged
@olliefreeman olliefreeman added this to the 4.12.0 milestone Nov 30, 2021
olliefreeman added a commit that referenced this issue Nov 30, 2021
@olliefreeman
Merge pull request #202 from MauroDataMapper/feature/gh-180
7838f7c 
gh-180 add filtering by namespace (ns), key and value
@olliefreeman olliefreeman modified the milestones: 4.12.0, 5.0.0 Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronforshaw aaronforshaw

Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

gh-180 add filtering by namespace (ns), key and value MauroDataMapper/mdm-core
3 participants
@jamesrwelch @olliefreeman @aaronforshaw