Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile - Change "Value cannot be null" validation message to be user-friendly #135

Closed
pjmonks opened this issue Aug 20, 2021 · 1 comment · Fixed by #148
Closed

Profile - Change "Value cannot be null" validation message to be user-friendly #135

pjmonks opened this issue Aug 20, 2021 · 1 comment · Fixed by #148
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@pjmonks
Copy link
Contributor

pjmonks commented Aug 20, 2021

Describe the bug
If editing a profile which has mandatory fields, if a user left out a field value and then validates the profile then a validation message "Value cannot be null" is returned.

Expected behavior
This is correct. However, from a user experience perspective, the validation message looks a bit too technical and unfriendly.

The suggested improvement is to update mdm-plugin-profile/grails-app/i18n/messages.properties with more user-friendly messages. For example:

"This field cannot be empty"

Screenshots
image

@pjmonks pjmonks added the enhancement New feature or request label Aug 20, 2021
@olliefreeman
Copy link
Contributor

please check mdm-application-build does NOT override the appropriate message, and if so, also update MAB

@joe-crawford joe-crawford linked a pull request Sep 22, 2021 that will close this issue
olliefreeman added a commit that referenced this issue Oct 4, 2021
@olliefreeman olliefreeman added this to the 4.11.0 milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants