Be less strict about what the tagName of a <style> tag must be
#486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we check to see if a node is a `<style>` tag by checking if the `node.tagName === 'STYLE'`. However, it seems in some cases it can be lowercase `'style'` instead, and possibly some browsers or users might make it something else. This change adds resiliency to the check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #485
Currently we check to see if a node is a
<style>tag by checkingif the
node.tagName === 'STYLE'. However, it seems in some casesit can be lowercase
'style'instead, and possibly some browsersor users might make it something else. This change adds resiliency
to the check.