Attempt at fix for changing spinner items

MattJAshworth · Jan 20, 2025 · 68ad6b2 · 68ad6b2
1 parent 14e817e
commit 68ad6b2
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 7 deletions.
diff --git a/SpinnerTools/build.gradle.kts b/SpinnerTools/build.gradle.kts
@@ -43,7 +43,7 @@ android {
                     from(components["release"])
                     groupId = "xyz.mattjashworth.spinnertools"
                     artifactId = "SpinnerTools"
-                    version = "1.4"
+                    version = "1.4.5"
                 }
             }
         }

diff --git a/SpinnerTools/src/main/java/xyz/mattjashworth/spinnertools/sheet/Spinner.kt b/SpinnerTools/src/main/java/xyz/mattjashworth/spinnertools/sheet/Spinner.kt
@@ -95,7 +95,7 @@ class Spinner<T>(context: Context, attributeSet: AttributeSet) : LinearLayout(co
         selectedItem.setTextColor(textColor ?: context.getColor(android.R.color.black))
 
         setChildListener(rootView, OnClickListener {
-            val s = SpinnerSheet<T>(context, items, title, displayMember, searchable)
+            val s = SpinnerSheet<T>(context, this.items, title, displayMember, searchable)
             if (selectedObject != null)
                 s.setSelectedObject(selectedObject!!)
             s.setOnItemClickListener(object : SpinnerSheet.OnSearchSpinnerClickListener<T> {

diff --git a/SpinnerTools/src/main/java/xyz/mattjashworth/spinnertools/sheet/SpinnerSheet.kt b/SpinnerTools/src/main/java/xyz/mattjashworth/spinnertools/sheet/SpinnerSheet.kt
@@ -30,6 +30,7 @@ internal class SpinnerSheet<T>(context: Context, items: ArrayList<T>, title: Str
 
     init {
 
+        filteredItems = ArrayList(items.toList())
 
         diag = BottomSheetDialog(context)
         val layoutInflater = LayoutInflater.from(context)

diff --git a/sample/src/main/java/xyz/mattjashworth/sample/MainActivity.kt b/sample/src/main/java/xyz/mattjashworth/sample/MainActivity.kt
@@ -8,6 +8,10 @@ import androidx.appcompat.app.AppCompatActivity
 import androidx.core.view.ViewCompat
 import androidx.core.view.WindowInsetsCompat
 import com.google.android.material.snackbar.Snackbar
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.delay
+import kotlinx.coroutines.launch
 import xyz.mattjashworth.spinnertools.sheet.Spinner
 
 class MainActivity : AppCompatActivity() {
@@ -60,15 +64,22 @@ class MainActivity : AppCompatActivity() {
             )
 
 
-        val searchSpinner = findViewById<Spinner<ExampleObject>>(R.id.app_spinner)
-        searchSpinner.setItems(data)
-        searchSpinner.setOnItemSelectedListener(object : Spinner.OnItemSelectedListener<ExampleObject> {
-            override fun onItemSelected(model: ExampleObject) {
-                Snackbar.make(rootView, model.name, Snackbar.LENGTH_LONG).show()
+        val searchSpinner = findViewById<Spinner<String>>(R.id.app_spinner)
+        searchSpinner.setItems(arrayListOf("One", "Two", "Three", "Four", "Five", "Six"))
+        searchSpinner.setOnItemSelectedListener(object : Spinner.OnItemSelectedListener<String> {
+            override fun onItemSelected(model: String) {
+                Snackbar.make(rootView, model, Snackbar.LENGTH_LONG).show()
             }
 
         })
 
+        CoroutineScope(Dispatchers.IO).launch {
+            delay(10000)
+            runOnUiThread {
+                searchSpinner.setItems(arrayListOf("One"))
+            }
+        }
+
-Original file line number
+Diff line change
@@ Expand Up @@
         init {
+            filteredItems = ArrayList(items.toList())
             diag = BottomSheetDialog(context)
             val layoutInflater = LayoutInflater.from(context)
@@ Expand Down @@