-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test suite + test example for JS #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As noted in the issue, this should be fully testing the behaviour of the generate
method, but also the private methods involved in the generation process.
See the Ruby gem test suite for inspiration: https://github.com/MattIPv4/do_username/blob/master/ruby/spec/do_username_spec.rb
sorry @MattIPv4, did not pay attention to that. I add all the tests the ruby package does expect for the Besides that, I did the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for not getting to this sooner, not sure why I lost track of updates here a while back. LGTM, tyvm!
Using jest as the test engine.
Also add a test for the function, asserting it's
maxSize
argument.Closes #17