-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Override key generation for all tests #420
Labels
Comments
10 tasks
tegefaulkes
added a commit
that referenced
this issue
Jul 19, 2022
tegefaulkes
added a commit
that referenced
this issue
Jul 26, 2022
tegefaulkes
added a commit
that referenced
this issue
Jul 26, 2022
tegefaulkes
added a commit
that referenced
this issue
Jul 26, 2022
tegefaulkes
added a commit
that referenced
this issue
Jul 27, 2022
This should allow for faster testing since we skip the CPU intensive keypair generation. Related #420
tegefaulkes
added a commit
that referenced
this issue
Jul 27, 2022
tegefaulkes
added a commit
that referenced
this issue
Jul 27, 2022
This should allow for faster testing since we skip the CPU intensive keypair generation. Related #420
tegefaulkes
added a commit
that referenced
this issue
Jul 27, 2022
4 tasks
tegefaulkes
added a commit
that referenced
this issue
Aug 8, 2022
Moved `tests/utils.ts` to `tests/utils/utils.ts` and created `test/utils/index.ts`. Trying to keep the utils within one place. Removed `setupGlobalAgent` code, #420 means it isn't used anymore. Updating how we handle conditional testing utility's. we're switching to using reified booleans and just composing conditional boolean expression. #434
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Specification
With the changes from #404 it is now possible to skip key generation all together. So far this optimisation has been applied to the bin tests but now we need to apply it to the rest of the jest tests.
This can be done by taking every instance of
createPolykeyAgent
and adding the followingkeysConfig
parameter to it. CurrentlyglobalRootKeyPems
contains 10 pre-generated private key Pems.If there are any instances of a
polykey agent start
bin command being used then you can use the followingPK_ROOT_KEY: globalRootKeyPems[0]
Env variable.Any Polykey agents that are created inside a
beforeAll
should now be done inside thebeforeEach
. This will give better test isolation.Additional context
Tasks
createPolykeyAgent
to use the above config to skip key generation.beforeAll
to usebeforeEach
.The text was updated successfully, but these errors were encountered: