Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating CI integration testing #94

Merged
merged 7 commits into from
Jan 17, 2024
Merged

Conversation

tegefaulkes
Copy link
Contributor

@tegefaulkes tegefaulkes commented Jan 15, 2024

Description

This PR addresses the changes needed for automated CI integration testing.

Issues Fixed

Tasks

  • 1. Verify the lambda is triggering the deployment properly.
  • 2. Remove the part of the CI job integration:deployment that triggers the tasks restarting.
  • 4. The wait-for-deployment.js needs to be parameterised to work with the testnet and mainnet.
  • 5. The integration tests need to be parameterised to work with the testnet and mainnet.
  • 6. The wait-for-deployment.js script needs to take into account the CLI version on top of the library version.
  • 7. we need to add a wait-for-deployment ci job for the mainnet stage.
  • 8. We need add integration tests ci job for the mainnet stage.

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@tegefaulkes tegefaulkes self-assigned this Jan 15, 2024
@ghost
Copy link

ghost commented Jan 15, 2024

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@tegefaulkes
Copy link
Contributor Author

For now I'm only going to add the docker integration tests to the release stage. It's the only integration test that even attempts connections to the network.

@tegefaulkes
Copy link
Contributor Author

Mostly done, just blocked by the CLI version being available on the https://testnet.polykey.com/api/seednodes/status endpoint and modifying the wait-for-deploy.js script.

Service deployment depends on the new lambda script.

[ci skip]
…net`

The network can be set with `PK_NETWORK` env variable, it will be used where relevant in tests.

[ci skip]
This will wait for the seed nodes to update after deploying.

[ci skip]
@tegefaulkes tegefaulkes force-pushed the feature-integration-ci-changes branch from 9e92a94 to b508ee1 Compare January 17, 2024 00:00
@tegefaulkes
Copy link
Contributor Author

This is pretty much done now but I can't fully test it without some release versions in the staging branch. So the next step is testing in staging with some test release versions.

@tegefaulkes tegefaulkes marked this pull request as ready for review January 17, 2024 02:08
@tegefaulkes
Copy link
Contributor Author

Ready to merge now.

@CMCDragonkai CMCDragonkai changed the title updating CI integration testing Updating CI integration testing Jan 17, 2024
@CMCDragonkai
Copy link
Member

CMCDragonkai commented Jan 17, 2024

Make sure to start testing, and @amydevs we need that table on #599 up so we can see that's it working end to end.

@tegefaulkes tegefaulkes merged commit a5a9ac5 into staging Jan 17, 2024
1 check passed
@CMCDragonkai CMCDragonkai added the r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices label Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices
Development

Successfully merging this pull request may close these issues.

Remove deployment triggering from CI job
2 participants