Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[explain] change test framework to explicitly use EXPLAIN OPTIMIZED PLAN FOR #31185

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[explain] change test framework to explicitly use EXPLAIN OPTIMIZED PLAN FOR #31185

wants to merge 5 commits into from

Conversation

mgree
Copy link
Contributor

@mgree mgree commented Jan 24, 2025

Before we can make any changes in how EXPLAIN PLAN FOR works, we have to make sure that those changes won't break our testing infrastructure. Wherever a test previously asked for EXPLAIN PLAN FOR ..., we now force it to ask for the OPTIMIZED PLAN, i.e., the result after MIR optimization. Then we can change the default and tests won't mind.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@mgree mgree added T-testing Theme: tests or test infrastructure T-observability A-CLUSTER Topics related to the CLUSTER layer labels Jan 24, 2025
@mgree mgree requested review from a team as code owners January 24, 2025 19:52
@mgree mgree requested a review from aljoscha January 24, 2025 19:52
@mgree mgree marked this pull request as draft January 24, 2025 20:55
ggevay
ggevay reviewed Jan 25, 2025
View reviewed changes
bin/version-consistency-explain-test
@@ -11,4 +11,4 @@
#
# version-consistency-explain-test - Test the explain plan consistency on different versions of mz.

exec "$(dirname "$0")"/pyactivate -m materialize.version_consistency.version_consistency_test --query-output-mode EXPLAIN --max-cols-per-query=4 --avoid-expressions-expecting-db-error "$@"
exec "$(dirname "$0")"/pyactivate -m materialize.version_consistency.version_consistency_test --query-output-mode "EXPLAIN OPTIMIZED PLAN" --max-cols-per-query=4 --avoid-expressions-expecting-db-error "$@"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FOR is missing after EXPLAIN OPTIMIZED PLAN.

def-
def- approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to be explicit, so fine for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggevay ggevay ggevay left review comments

@def- def- def- approved these changes

@aljoscha aljoscha Awaiting requested review from aljoscha aljoscha is a code owner automatically assigned from MaterializeInc/adapter

Assignees
No one assigned
Labels
A-CLUSTER Topics related to the CLUSTER layer T-observability T-testing Theme: tests or test infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgree @def- @ggevay