Opening fullscreen and leaving fullscreen enables UI menubar even when turned off

[bjornpijnacker]

Opening the fullscreen mode from the player and closing it with escape enables the menu bar even when the menubar is turned off in settings. Turning the menubar off requires going to the settings, then enabling and disabling the menubar. See attached video for more information (https://user-images.githubusercontent.com/35508080/148688503-789179d3-fc96-40ab-a945-1bf08c8963d3.mp4).

Exact steps to reproduce:

1. Open the now playing window by clicking the bottom bar or the arrow in the bottom right corner
2. In the top left, choose "Full Screen"
3. Close fullscreen mode by pressing Esc
4. The menu bar is now visible while it should not be.

[Mastermindzh]

Hey @bjornpijnacker,

I can easily recreate the issue. I don't know when I'll have the time to look into it but it is definitely a bug 😄.
Thanks!

[bjornpijnacker]

Thanks!

Just googling real quick makes it seem like this is a bug in Electron rather than tidal-hifi. A potential fix is shown here: jupyterlab/jupyterlab-desktop@12819f9, which is how jupyterlab fixed the issue.

[Mastermindzh]

Hey @bjornpijnacker,

Yeah, I knew it was an electron issue since we don't do anything with fullscreen ourselves.
Funnily enough, the fix is nearly identical to the one I had in my mind 😂 (except variable names and I'd use the store).

Tell me, is this affecting your day to day usage? I think I can make some extra time tonight if this has any kind of priority 🤷🏻

[bjornpijnacker]

Hey!

It's not really affecting my day-to-day, as I don't use fullscreen all too often. In my opinion: no need to drop everything and fix it right away, it can wait until you have the time.

It's a small fix, luckily (:

[Mastermindzh]

Hey @bjornpijnacker,

The fix was a bit more elaborate (though not much..) because it isn't actually us (Tidal-hifi) that enables fullscreen but rather listen.tidal.com.

Because of that, I had to add an event listener which triggered an event for the main process.

This event is listened to in the main process and it updates the menubar to whatever setting the user has in their settings.

Builds are now running. I expect a 2.7.1 release within the hour.

[Mastermindzh]

Released in 2.7.1

[bjornpijnacker]

It works great, thanks!