-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case insensitive tags #64
Conversation
fixes #63
Why shouldn't it be applied to XML tags? |
Html is case insensitive, xml not ( |
Does this work? zhaofengli/html5-php@b726aeb |
@technosophos what is your opinion about this? |
I think @zhaofengli is on the right track, and I think There may be a case in SVG (@mattfarina would know) where the SVG name matches the HTML name, but I don't think that will make a significant different here. I made a quick suggestion on the patch itself. And we should definitely write some tests to make sure this is working. But otherwise I think we should keep going with that patch. |
@technosophos Okay, I've made zhaofengli/html5-php@d505c3f . It's a bit difficult to test the case-sensitive (non-HTML5) scenario at the moment IMO, as |
For reference, SVG is XML. So, it follows XML rules. HTML 5 is where things get different. There is a nice little reference on case sensitivity at http://www.w3.org/TR/html-markup/documents.html#case-insensitivity. I remember this exact problem when we were originally writing it. I wanted to come back and fix it but never did. Would it be worth testing that XML cases fail when the case is off? An SVG and MathML test would be useful. |
BTW, looking at This PR will affect only rcdata tags as @mattfarina If you are interested to have tests about failing test cases in svg or mathml, this will not affect this PR. |
This should fix #63, but how to apply it only to HTML5 tags, and not to XML tags?