Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in storing encoder steps #383

Merged
merged 1 commit into from
Feb 5, 2018
Merged

Fix bug in storing encoder steps #383

merged 1 commit into from
Feb 5, 2018

Conversation

reecej
Copy link
Contributor

@reecej reecej commented Feb 4, 2018

Fix bug where encoder steps are overwritten each time the board is booted up. This is related to the chain on bottom functionality, although the bug occurs whether the chain is on top or bottom.

Fix bug where encoder steps are overwritten each time the board is booted up.
@reecej reecej mentioned this pull request Feb 4, 2018
Copy link
Collaborator

@blurfl blurfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested and confirmed that this works with these use cases:

  • upgrading from v1.04 firmware (requires chain cal, as expected) using GCv1.04
  • upgrading from v1.05 master before this PR (did not require chain cal) using GCv10.5-master

@krkeegan
Copy link
Collaborator

krkeegan commented Feb 5, 2018

I gather that it wasn't working to call setupAxis() after loading the steps from eeprom?

@reecej
Copy link
Contributor Author

reecej commented Feb 5, 2018

Correct. When setupAxes() was run, it would read the current encoder position and set the steps to that value, really just to initialize the values. But that was overwriting our loaded previous steps value, and hence the chains were having to be recalibrated at every system boot.

@BarbourSmith
Copy link
Member

This works great for me as well. No need to do the chain re-cal 👍 👍 Excellent job tracking down what the issue was!

@BarbourSmith BarbourSmith merged commit 2a3c159 into MaslowCNC:master Feb 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants