vcredist: use unique file names for 32-bit and 64-bit installers #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a clean Windows 8.1 x64 virtual machine, running on rather old hardware and with quite limited resources (i.e. slow), I have observed the following behavior while installing vcredist2013*: 1) Chocolatey downloads and installs the 64-bit version successfully 2) Chocolatey proceeds to download the installer for the 32-bit version, using the same local file name as for the 64-bit version (vcredist2013Install.exe). 3) The download fails, because the destination file is used by another process. I believe this happens because, due to the slowness of the machine, although the 64-bit vcredist installation has finished from Chocolatey point of view, a system component (the Windows Installer service?) is still holding the installer file open for a brief amount of time. This is definitely a timing-related issue, because I have not been able to reproduce it on an identical VM running on better hardware with more resources. Since the local installer file name is determined by the packageName argument to Install-ChocolateyPackage, let's avoid the problem by using a different name for the 32-bit installer on 64-bit OS. * Although I personally encountered the issue while installing the 2013 redist, it could happen for all other redists, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a clean Windows 8.1 x64 virtual machine, running on rather old hardware
and with quite limited resources (i.e. slow), I have observed the
following behavior while installing vcredist2013(*):
using the same local file name as for the 64-bit version
(vcredist2013Install.exe).
another process.
I believe this happens because, due to the slowness of the machine,
although the 64-bit vcredist installation has finished from Chocolatey
point of view, a system component (the Windows Installer service?) is
still holding the installer file open for a brief amount of time. This is
definitely a timing-related issue, because I have not been able to
reproduce it on an identical VM running on better hardware with more
resources.
Since the local installer file name is determined by the packageName
argument to Install-ChocolateyPackage, let's avoid the problem by using a
different name for the 32-bit installer on 64-bit OS.
(*) Although I personally encountered the issue while installing the 2013
redist, it could happen for all other redists, too.