#3687 Remove analyzer that checks for the Serializable attribute

MarimerLLC · Apr 24, 2024 · b612630 · b612630
1 parent 4f389e7
commit b612630
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 128 deletions.
diff --git a/Source/Csla.Analyzers/Csla.Analyzers/AnalyzerReleases.Unshipped.md b/Source/Csla.Analyzers/Csla.Analyzers/AnalyzerReleases.Unshipped.md
@@ -4,7 +4,6 @@
 ### New Rules
 Rule ID | Category | Severity | Notes
 --------|----------|----------|-------
-CSLA0001 | Usage | Error | IsBusinessObjectSerializableAnalyzer
 CSLA0002 | Design | Warning | IsOperationMethodPublicAnalyzer
 CSLA0003 | Usage | Error | CheckConstructorsAnalyzer
 CSLA0004 | Usage | Warning | CheckConstructorsAnalyzer

diff --git a/Source/Csla.Analyzers/Csla.Analyzers/Constants.cs b/Source/Csla.Analyzers/Csla.Analyzers/Constants.cs
@@ -4,7 +4,6 @@ public static class Constants
   {
     public static class AnalyzerIdentifiers
     {
-      public const string IsBusinessObjectSerializable = "CSLA0001";
       public const string IsOperationMethodPublic = "CSLA0002";
       public const string PublicNoArgumentConstructorIsMissing = "CSLA0003";
       public const string ConstructorHasParameters = "CSLA0004";

diff --git a/Source/Csla.Analyzers/Csla.Analyzers/FindOperationsWithNonSerializableArgumentsAnalyzer.cs b/Source/Csla.Analyzers/Csla.Analyzers/FindOperationsWithNonSerializableArgumentsAnalyzer.cs
@@ -45,7 +45,7 @@ private static void AnalyzeMethodDeclaration(SyntaxNodeAnalysisContext context)
               !argumentType.IsSerializableByMobileFormatter(context.Compilation) &&
               !argument.GetAttributes().Any(_ => _.AttributeClass.IsInjectable()) && 
               argumentType is not { ContainingNamespace.Name: "System", Name: "Nullable" } &&
-              argumentType is INamedTypeSymbol namedArgument && !namedArgument.IsSerializable)
+              argumentType is INamedTypeSymbol namedArgument)
           {
             context.ReportDiagnostic(Diagnostic.Create(
               shouldUseSerializableTypesRule, argument.Locations[0]));

diff --git a/Source/Csla.Analyzers/Csla.Analyzers/IsBusinessObjectSerializableAnalyzer.cs b/Source/Csla.Analyzers/Csla.Analyzers/IsBusinessObjectSerializableAnalyzer.cs
diff --git a/Source/Csla.Analyzers/Csla.Analyzers/IsBusinessObjectSerializableConstants.cs b/Source/Csla.Analyzers/Csla.Analyzers/IsBusinessObjectSerializableConstants.cs
diff --git a/Source/Csla.Analyzers/Csla.Analyzers/IsBusinessObjectSerializableMakeSerializableCodeFix.cs b/Source/Csla.Analyzers/Csla.Analyzers/IsBusinessObjectSerializableMakeSerializableCodeFix.cs