Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General update #28

Merged
merged 26 commits into from
Jul 30, 2021
Merged

General update #28

merged 26 commits into from
Jul 30, 2021

Conversation

Malvoz
Copy link
Member

@Malvoz Malvoz commented Jul 22, 2021 •
edited
Loading

Overview of changes

Documentation

HTML markup examples

Site functionality/visuals

  • c6b059c Fixes an issue that causes a flash of black background-color in the .heroBanner (holds the home page's map viewer).
  • 1533b85: Restrict some elements used in body to a max-width of 80 characters for readability.
  • 63b38af: Add title to the map viewer iframe.
  • 16f16f8: Set the duplicate "mobile" menu to display: none on larger screen sizes, such that keyboard users don't tab to hidden menu items.
  • 8befc56: Fix more Docusaurus keyboard tabbing issues.
  • fd92049: Improve visibility of the bottom menu button on mobile.
  • 1111cfd: Correct heading levels (if we want smaller headings than the default we should use CSS). Notably this commit also changes some content in installation.md because not all steps of "Using a Downloaded Version" is applicable to the Clone the repository alternative.

Link fixes/additions

  • 93d5a7e + 5f5fbcc: Replace "here" or "this" link text with descriptive text.
  • 0293a85: Link to support data for customized built-in elements.
  • ff7d002: Rename one of the 2 links named "Github Repository" to "issues" (and link to the issue overview).
  • d8be2f1: Add link to the MapML spec where the term is first used.
  • 14a3e07: Add link to the Maps4HTML channel on YouTube in site's footer.

Other

  • 56a9107: Use <p> instead of <br>.

Malvoz and others added 25 commits July 22, 2021 15:42
@Malvoz
Fix flash of black background-color in .heroBanner
c6b059c
@Malvoz
Mention screen readers under 'Accessible Maps'
b5d54a1
@Malvoz
State that OSMTILE is the default projection
7f4df80
@Malvoz
Mention accessibility issue of built-in elements due to Chromium bug
a68035e
@Malvoz
Link to CaniUse (MDN) support data for Customized built-in elements
0293a85
@Malvoz
s/Requreiments/Requirements
ab7460a
@Malvoz
Replace a few "here" descriptions in links with descriptive text
93d5a7e
@Malvoz
Restrict elements used in body to a max-width of 80 characters
1533b85
@Malvoz
Rename second link named "Github Repository" to "issues" (and link th…
ff7d002 
…ere)
@Malvoz
Add back html, body { height: 100%; }
b47199c
@Malvoz
Add link to YouTube in footer
14a3e07
@Malvoz
Add link to the MapML spec where the term is first used
d8be2f1
@Malvoz
Add title to the map viewer iframe
63b38af
@Malvoz
Set the duplicate menu to display: none on larger screen sizes
16f16f8
@Malvoz
More fixes for descriptive link text
5f5fbcc
@Malvoz
Improve visibility of secondary menu button
fd92049
@Malvoz
Remove duplicate <body> element in HTML example
e6b3dd0
@Malvoz
Uniform indentation in HTML examples (tab size: 2)
b025a41
@Malvoz
s/contantly/constantly
ce70e93
@Malvoz
Use <p> instead of <br>
56a9107
@Malvoz
Correct heading levels
1111cfd
@Malvoz
Remove whitespace in the installation.md HTML example
584859b
@Malvoz
Merge branch 'master' into general-update
6d01a5f
@Malvoz
<layer> => <layer->
3b6006c
@Malvoz
Merge branch 'master' into general-update
682a020
@Malvoz Malvoz mentioned this pull request Jul 29, 2021
Closed
@Malvoz Malvoz merged commit f1aaedf into Maps4HTML:master Jul 30, 2021
@Malvoz Malvoz deleted the general-update branch July 30, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Malvoz