Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with standalone maps not always spanning the entire visible viewport #93

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

Malvoz
Copy link
Member

@Malvoz Malvoz commented Feb 7, 2022

This is an attempt to prevent the gap below the map after exiting fullscreen:

by setting position: fixed, ref: https://developers.google.com/web/updates/2016/12/url-bar-resizing.

@Malvoz Malvoz merged commit 5db0026 into Maps4HTML:main Feb 7, 2022
@Malvoz
Copy link
Member Author

Malvoz commented Feb 7, 2022

Seems to have worked. There are other ways to ensure URL Bar Resizing does not result in parts of maps being covered by the browser's chrome, or the map not spanning the entire visible viewport (e.g. using height: 100vh, though that's got its own set of problems: https://github.com/postcss/postcss-100vh-fix#postcss-100vh-fix).

This may be useful information for Maps4HTML/web-map-doc#26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant