Add controlslist content attribute and controlsList IDL
#127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aligns better with with WHATWG's style.
|
Allowed keywords are I suppose we could add |
Malvoz
commented
Sep 27, 2020
| @@ -625,7 +630,8 @@ <h4>The <code><<dfn id="the-map-element">map</dfn>></code> element</h4> | |||
| <dd><code id="attr-map-lat">lat</code> — A decimal WGS84 latitude value for the map center.</dd> | |||
| <dd><code id="attr-map-lon">lon</code> — A decimal WGS84 longitude value for the map center.</dd> | |||
| <dd><code id="attr-map-projection">projection</code> — A case-sensitive string <a href="#tiled-coordinate-reference-systems-table">identifier</a> of the MapML coordinate reference system used by the map. Default is <a href="#tcrs-OSMTILE"><code>OSMTILE</code></a>.</dd> | |||
| <dd><code id="attr-map-controls">controls</code> — Show user agent map controls.</dd> | |||
| <dd><code id="attr-map-controls">controls</code> — Show user agent controls.</dd> | |||
| <dd><code>controlslist</code> — Show/hide specific user agent controls.</dd> | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
prushforth
approved these changes
Sep 28, 2020
There was a problem hiding this comment.
This looks good to me. By adding the nozoom and nolayer keywords, we should add these to an issue in the web-map-custom-element, in order to keep track of what is not implemented yet and keep the polyfill reflecting the spec, although I realize there may be current gaps and overshoots. But anyway, looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #99.
Mostly copy pasta from https://wicg.github.io/controls-list/html-output/multipage/embedded-content.html#attr-media-controlslist, with small modifications since this is about maps and not video.
A little reminder that
controlslistmay not be sufficient per @AmeliaBR's Maps4HTML/HTML-Map-Element-UseCases-Requirements#16 (comment), until someone comes along with a concrete proposal we should probably use what's currently on the web.