Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing semver package to package requirements #8

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

frenck
Copy link
Contributor

@frenck frenck commented Mar 14, 2024

fixes #7

@bouwew
Copy link
Contributor

bouwew commented Mar 15, 2024

Looking at this: 6b4bdc3 it needs to be: semver ==2.13.0

@frenck
Copy link
Contributor Author

frenck commented Mar 15, 2024

Sounds not good. Libraries should never strict pin requirements in their package. I think you are misunderstanding the lock file construct used here.

@bouwew
Copy link
Contributor

bouwew commented Mar 15, 2024

After further reading I found out that semver.compare is depreciated so better to fix this: python-semver/python-semver#236 (comment)

I've done some more reading, semver.compare is not depreciated so the proposed change should fix the issue.

@ManneW please test and merge this PR, and release and update the vilfo-integration.

As far as I can see it's about the semver.compare use, that's the link to the specific semver version.
If the version-number should not be used then the relevant code needs some reworking I'm thinking.

@ManneW ManneW merged commit d37c119 into ManneW:master Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugwise backend bump breaks the HA vilfo integration
3 participants