Bug 1224580. Copy of URLSearchParams should not copy its observer poi…

…nter. r=baku
Manishearth · Nov 16, 2015 · b9ac672 · b9ac672
1 parent f4152a3
commit b9ac672
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/dom/base/URLSearchParams.cpp b/dom/base/URLSearchParams.cpp
@@ -315,7 +315,7 @@ URLSearchParams::URLSearchParams(nsISupports* aParent,
                                  const URLSearchParams& aOther)
   : mParams(new URLParams(*aOther.mParams.get()))
   , mParent(aParent)
-  , mObserver(aOther.mObserver)
+  , mObserver(nullptr)
 {
 }
 

diff --git a/dom/base/test/test_urlSearchParams.html b/dom/base/test/test_urlSearchParams.html
@@ -300,6 +300,20 @@
     runTest();
   }
 
+  function testCopyConstructor() {
+    var url = new URL("http://example.com/");
+    var p = url.searchParams;
+    var q = new URLSearchParams(p);
+    q.set("a", "b");
+    is(url.href, "http://example.com/",
+       "Messing with copy of URLSearchParams should not affect URL");
+    p.set("c", "d");
+    is(url.href, "http://example.com/?c=d",
+       "Messing with URLSearchParams should affect URL");
+
+    runTest();
+  }
+
   var tests = [
     testSimpleURLSearchParams,
     testCopyURLSearchParams,
@@ -314,6 +328,7 @@
     testSet,
     testIterable,
     testZeroHandling,
+    testCopyConstructor,
   ];
 
   function runTest() {