-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3098 Refining documentations for moving_camera_scene module #3972
3098 Refining documentations for moving_camera_scene module #3972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me, one minor comment, and then I believe it's good to go.
Thanks for helping make Manim better ✨
manim/scene/moving_camera_scene.py
Outdated
Note: Examples are included in the moving_camera_scene module | ||
documentation, see below in the 'see also' section. | ||
.. SEEALSO:: | ||
|
||
:mod:`.moving_camera_scene` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This renders incorrectly, we might need an extra line before and after the .. SEEALSO::
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I have added the change
…dule' of https://github.com/Jackyuanx/manim into 3098-Refining-documentations-for-moving_camera_scene-module
for more information, see https://pre-commit.ci
Thank you! We have added extra line before and after .. SEEALSO::. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks good to me! Thanks for adding this example.
Overview: What does this pull request change?
This closes #3098 by referencing the moving_camera_scene module documentation, and adding an additional example provided by MrDiver
Motivation and Explanation: Why and how do your changes improve the library?
This closes #3098
Links to added or changed documentation pages
This affects MovingCameraScene and moving_camera_scene
Reviewer Checklist