Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typehints of ParametricFunction #3926

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Fix typehints of ParametricFunction #3926

merged 2 commits into from
Oct 22, 2024

Conversation

JasonGrace2282
Copy link
Member

@JasonGrace2282 JasonGrace2282 added the typehints For adding/discussing typehints label Sep 1, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 1, 2024
View reviewed changes
manim/mobject/mobject.py Dismissed Show dismissed Hide dismissed
chopan050
chopan050 requested changes Oct 20, 2024
View reviewed changes
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Could you please also add typehints for the get_function() and get_point_from_function() methods?

chopan050
chopan050 approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chopan050 chopan050 changed the title Fix typehints of ParametricFunction Fix typehints of ParametricFunction Oct 22, 2024
@chopan050 chopan050 enabled auto-merge (squash) October 22, 2024 13:51
@chopan050 chopan050 merged commit 96e58ae into ManimCommunity:main Oct 22, 2024
19 checks passed
@JasonGrace2282 JasonGrace2282 deleted the issue-3917 branch October 22, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chopan050 chopan050 chopan050 approved these changes

Assignees
No one assigned
Labels
typehints For adding/discussing typehints
Projects
Dev Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ParametricFunction: wrong type hint
2 participants
@JasonGrace2282 @chopan050