Skip to content

Commit

Permalink
Draw more accurate circular Arcs for larger angles (#4034)
Browse files Browse the repository at this point in the history
Co-authored-by: Benjamin Hackl <[email protected]>
  • Loading branch information
chopan050 and behackl authored Jan 19, 2025
1 parent bad88a1 commit 8bb28aa
Show file tree
Hide file tree
Showing 188 changed files with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions manim/mobject/geometry/arc.py
Original file line number Diff line number Diff line change
Expand Up @@ -394,8 +394,9 @@ def _set_pre_positioned_points(self) -> None:
tangent_vectors[:, 1] = anchors[:, 0]
tangent_vectors[:, 0] = -anchors[:, 1]
# Use tangent vectors to deduce anchors
handles1 = anchors[:-1] + (d_theta / 3) * tangent_vectors[:-1]
handles2 = anchors[1:] - (d_theta / 3) * tangent_vectors[1:]
factor = 4 / 3 * np.tan(d_theta / 4)
handles1 = anchors[:-1] + factor * tangent_vectors[:-1]
handles2 = anchors[1:] - factor * tangent_vectors[1:]
self.set_anchors_and_handles(anchors[:-1], handles1, handles2, anchors[1:])

def get_arc_center(self, warning: bool = True) -> Point3D:
Expand Down
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/boolean_ops/exclusion.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/boolean_ops/union.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/brace/arcBrace.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/brace/braceTip.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/creation/FadeIn.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/creation/FadeOut.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/creation/SpiralIn.npz
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/creation/create.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/creation/uncreate.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/Angle.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/Annulus.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/Arc.npz
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/Arrange.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/Circle.npz
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/Coordinates.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/CurvedArrow.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/Dot.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/DoubleArrow.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/Elbow.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/Ellipse.npz
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/LabeledLine.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/Line.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/Polygon.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/Polygram.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/Rectangle.npz
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/RightAngle.npz
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/Sector.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/Star.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/Vector.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/geometry/ZIndex.npz
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/img_and_svg/Arcs01.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/img_and_svg/Arcs02.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/img_and_svg/Heart.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/img_and_svg/Line.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/img_and_svg/Penrose.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/img_and_svg/Rhomboid.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/img_and_svg/UKFlag.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/indication/ApplyWave.npz
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/indication/Flash.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/indication/FocusOn.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/indication/Indicate.npz
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/indication/Wiggle.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/logo/banner.npz
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/mobjects/become.npz
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/mobjects/match_style.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/plot/axes.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/plot/get_area.npz
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/plot/get_axis_labels.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/plot/get_graph_label.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/plot/plot_line_graph.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/plot/polar_graph.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/plot/t_label.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/specialized/Broadcast.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/speed/SpeedModifier.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/tables/DecimalTable.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/tables/IntegerTable.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/tables/MathTable.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/tables/MobjectTable.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/tables/Table.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/threed/Arrow3D.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/threed/Axes.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/threed/CameraMove.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/threed/CameraMoveAxes.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/threed/Cone.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/threed/Cube.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/threed/Cylinder.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/threed/Dot3D.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/threed/Line3D.npz
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/threed/Sphere.npz
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/threed/Torus.npz
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/threed/Y_Direction.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/transform/CyclicReplace.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/transform/Restore.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/transform/Transform.npz
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file modified tests/test_graphical_units/control_data/updaters/Updater.npz
Binary file not shown.
Binary file not shown.

0 comments on commit 8bb28aa

Please sign in to comment.