-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected values for DialogFieldDateTimeControl #398
Conversation
I've been using this Automate method (for a dialog with one checkbox and a date-time field) to verify the value get updated correctly for automate requests: trigger = $evm.root['dialog_trigger']
$evm.log('info', "======= trigger value #{trigger}")
if trigger == "t"
new_date = Time.utc(2019, 12, 24)
#new_date = '2019-12-24'
$evm.object['value'] = new_date
$evm.log('info', "======== new date #{$evm.object['value']}")
else # "f"
$evm.object['value'] = Time.utc(2021, 12, 24)
$evm.log('info', "======== clearing up date #{$evm.object['value']}")
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tag me to review after the rebase is done 👍
0b354dc
to
bd20eb4
Compare
@eclarizio please review |
Checked commit romanblanco@bd20eb4 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, but the spec needs to change to make the build green, will approve when that's good.
Added the change (and spec fix) as part of #399 |
This pull request is not mergeable. Please rebase and repush. |
result of discussion in #392:
#392 (comment)
#392 (comment)