Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected values for DialogFieldDateTimeControl #398

Closed

Conversation

romanblanco
Copy link
Member

result of discussion in #392:

#392 (comment)
#392 (comment)

@romanblanco
Copy link
Member Author

I've been using this Automate method (for a dialog with one checkbox and a date-time field) to verify the value get updated correctly for automate requests:

trigger = $evm.root['dialog_trigger']

$evm.log('info', "======= trigger value #{trigger}")
if trigger == "t"
  new_date = Time.utc(2019, 12, 24)
  #new_date = '2019-12-24'
  $evm.object['value'] = new_date
  $evm.log('info', "======== new date #{$evm.object['value']}")
else # "f"
  $evm.object['value'] = Time.utc(2021, 12, 24)
  $evm.log('info', "======== clearing up date #{$evm.object['value']}")
end

Copy link
Member

@eclarizio eclarizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tag me to review after the rebase is done 👍

@romanblanco romanblanco force-pushed the values-to-default_value branch from 0b354dc to bd20eb4 Compare July 2, 2019 11:22
@romanblanco
Copy link
Member Author

@eclarizio please review

@miq-bot
Copy link
Member

miq-bot commented Jul 2, 2019

Checked commit romanblanco@bd20eb4 with ruby 2.4.6, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Member

@eclarizio eclarizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, but the spec needs to change to make the build green, will approve when that's good.

@himdel
Copy link
Contributor

himdel commented Jul 8, 2019

Added the change (and spec fix) as part of #399

@miq-bot
Copy link
Member

miq-bot commented Jul 8, 2019

This pull request is not mergeable. Please rebase and repush.

@romanblanco romanblanco deleted the values-to-default_value branch July 10, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants