Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump manageiq-style for rexml CVEs #171

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

Fryguy
Copy link
Member

@Fryguy Fryguy commented Feb 3, 2025

@kbrock Please review. This should remove some of the Mend Bolt issues around rexml CVEs.

@Fryguy
Copy link
Member Author

Fryguy commented Feb 3, 2025

Dropping old Ruby versions in #172

@kbrock
Copy link
Member

kbrock commented Feb 3, 2025

sigh...

Maybe require different rubocop versions for different versions of ruby?
Or maybe drop ruby < 2.7. Locally anything older than 2.7 is too hard to wrangle gems into supporting.

    manageiq-style (>= 1.5.3) was resolved to 1.5.3, which depends on
      rubocop (= 1.56.3) was resolved to 1.56.3, which depends on
        Ruby (>= 2.7.0)

  Current Ruby version:
    Ruby (= 2.4.10)
Error: The process '/opt/hostedtoolcache/Ruby/2.4.10/x64/bin/bundle' failed with exit code 6

@Fryguy Fryguy closed this Feb 3, 2025
@Fryguy Fryguy reopened this Feb 3, 2025
@kbrock
Copy link
Member

kbrock commented Feb 3, 2025

@Fryguy please rebase

@Fryguy Fryguy force-pushed the bump_manageiq_style branch from e19c978 to 8dd4f1d Compare February 3, 2025 19:33
@Fryguy
Copy link
Member Author

Fryguy commented Feb 3, 2025

@kbrock Done.

@kbrock kbrock merged commit 3a15dac into ManageIQ:master Feb 4, 2025
10 checks passed
@Fryguy Fryguy deleted the bump_manageiq_style branch February 4, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants