Fix issues where active_support does not require logger properly #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fryguy
force-pushed
the
fix_logger_issues
branch
3 times, most recently
from
4cd8e99 to
4993cf2
Compare
Fryguy
force-pushed
the
fix_logger_issues
branch
from
4993cf2 to
eafb795
Compare
Fryguy
changed the title
Require logger due to active_support breaking on Rails <= 7.0. See rails/rails#54264
Fryguy
force-pushed
the
fix_logger_issues
branch
from
eafb795 to
6c9d2bd
Compare
|
Some comments on commits Fryguy/more_core_extensions@44f5885~...6c9d2bd spec/spec_helper.rb
|
|
Checked commits Fryguy/more_core_extensions@44f5885~...6c9d2bd with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint **
|
|
It's a shame we need to do this to support various rails versions in a library. |
Fryguy
added a commit
that referenced
this pull request
Jan 31, 2025
Fixed: - Fix issues where active_support does not require logger properly [#127]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require logger due to active_support breaking on Rails <= 7.0. See rails/rails#54264
Additionally, add testing of various activesupport versions