Specify the FQ class name for the provisioning manager #23330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rails 7.1 added validations here that raise in the foreman provider specs.
This commit resolves it for those specs:
3) ManageIQ::Providers::Foreman::Provider#destroy will remove all child objects
Failure/Error: provider.provisioning_manager.operating_system_flavors =
NameError:
Missing model class ProvisioningManager for the OperatingSystemFlavor#provisioning_manager association. You can specify a different model class with the :class_name option.
# ./spec/models/manageiq/providers/foreman/provider_spec.rb:50:in `block (3 levels) in <top (required)>'
# ------------------
# --- Caused by: ---
# NameError:
# uninitialized constant OperatingSystemFlavor::ProvisioningManager
# ./spec/models/manageiq/providers/foreman/provider_spec.rb:50:in `block (3 levels) in <top (required)>'
|
@miq-bot cross-repo-tests /providers |
miq-bot
pushed a commit
to ManageIQ/manageiq-cross_repo-tests
that referenced
this pull request
Feb 5, 2025
From Pull Request: ManageIQ/manageiq#23330
jrafanie
commented
Feb 5, 2025
| @@ -1,6 +1,6 @@ | |||
| class OperatingSystemFlavor < ApplicationRecord | |||
| acts_as_miq_taggable | |||
| belongs_to :provisioning_manager | |||
| belongs_to :provisioning_manager, :class_name => "ManageIQ::Providers::ProvisioningManager" | |||
There was a problem hiding this comment.
I believe this is a problem because this class is outside of the ManageIQ::Provider namespace so it doesn't resolve the name solely by the name of the association.
Fryguy
approved these changes
Feb 5, 2025
|
I'm kind of amazed this ever worked |
Agreed. It makes me worried how we can find others if they're not covered by tests. 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 7.1 added validations here that raise in the foreman provider specs. This commit resolves it for those specs:
Extracted from #23225