Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peg i18n gem to 1.13 #22545

Merged
merged 1 commit into from
Jun 2, 2023
Merged

peg i18n gem to 1.13 #22545

merged 1 commit into from
Jun 2, 2023

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Jun 2, 2023

There is an issue with 1.14 that breaks tests, and possibly functionality, too. Within 3 hours a number of people have referenced this issue so we are not alone

This is fixed by
ruby-i18n/i18n#662

Goal is to revert this once 1.15 goes live

There is an issue with 1.14 that breaks tests, and possibly functionality, too.
Within 3 hours a number of people have referenced this issue so we are not alone

This is fixed by
ruby-i18n/i18n#662
@kbrock kbrock requested a review from Fryguy as a code owner June 2, 2023 15:54
@miq-bot
Copy link
Member

miq-bot commented Jun 2, 2023

Checked commit kbrock@dc0ebc2 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Member

@jrafanie jrafanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrafanie jrafanie merged commit 6e11232 into ManageIQ:master Jun 2, 2023
@jrafanie jrafanie self-assigned this Jun 2, 2023
@kbrock kbrock deleted the peg_i18n branch June 2, 2023 18:10
kbrock added a commit to kbrock/manageiq that referenced this pull request Jun 6, 2023
This reverts commit 6e11232, reversing
changes made to b4c7593.
@Fryguy
Copy link
Member

Fryguy commented Jun 7, 2023

Backported to petrosian in commit ceb7df0.

commit ceb7df0584db6c409f365fff0595ab7ae7f04bd0
Author: Joe Rafaniello <[email protected]>
Date:   Fri Jun 2 12:39:33 2023 -0400

    Merge pull request #22545 from kbrock/peg_i18n
    
    peg i18n gem to 1.13
    
    (cherry picked from commit 6e1123215424d2197080836e6538b5f755d03496)

Fryguy pushed a commit that referenced this pull request Jun 7, 2023
peg i18n gem to 1.13

(cherry picked from commit 6e11232)
Fryguy added a commit to Fryguy/manageiq that referenced this pull request Jun 7, 2023
kbrock added a commit to kbrock/manageiq that referenced this pull request Jun 13, 2023
This reverts commit 6e11232, reversing
changes made to b4c7593.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants