Move Graph Refresh Settings to EMS #17931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gtanzillo found a few more places outside of the Refresher that were checking the settings directly. |
gtanzillo
reviewed
Aug 30, 2018
| @@ -78,6 +78,8 @@ def parse_targeted_inventory(ems, _target, inventory) | |||
| # ManagerRefresh::TargetCollection. This way we can do targeted refresh of all queued targets in 1 refresh | |||
| def preprocess_targets | |||
| @targets_by_ems_id.each do |ems_id, targets| | |||
| ems = ExtManagementSystem.find(ems_id) | |||
|
|
|||
| if targets.any? { |t| t.kind_of?(ExtManagementSystem) } | |||
| ems = @ems_by_ems_id[ems_id] | |||
There was a problem hiding this comment.
Could this line just be moved to where you added the new line setting ems
agrare
force-pushed
the
move_graph_refresh_settings_to_ems
branch
from
b54e42b to
ad3597a
Compare
bdunne
reviewed
Aug 30, 2018
app/models/ext_management_system.rb
Outdated
| @@ -718,6 +718,14 @@ def self.display_name(number = 1) | |||
| n_('Manager', 'Managers', number) | |||
| end | |||
|
|
|||
| def inventory_object_refresh? | |||
| Settings.ems_refresh[emstype].try(:[], :inventory_object_refresh) | |||
There was a problem hiding this comment.
You could use Settings.ems_refresh.fetch_path(ems_type, :inventory_obeject_refresh) to avoid the try
Move inventory_object_refresh? and allow_targeted_refresh? to ext_management_system so that code outside the Refresher can get away from checking settings directly.
agrare
force-pushed
the
move_graph_refresh_settings_to_ems
branch
from
ad3597a to
0aca388
Compare
|
Checked commit agrare@0aca388 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
bdunne
approved these changes
Aug 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move inventory_object_refresh? and allow_targeted_refresh? to
ext_management_system so that code outside the Refresher can get away
from checking settings directly.
Follow-up to #17916